🌐 Add Korean translation for docs/ko/docs/contributing.md
#4019
Conversation
There was a problem hiding this comment.
I think writing english words less would be better, like python, markdown and some headers and tip part are not translated yet. So please check my reviews.
Little bit hard to check the all of the sentences, words, etc. carefully. So, I'm in progress to check and share my opinion, and also those are not the answers. Just free to check mine 🚀
|
|
||
| ## 개발 | ||
|
|
||
| 이미 저장소를 Clone했고, 코드를 조사하게 알고싶은 경우에 환경 구축을 위한 몇 가지 가이드라인이 있습니다. |
There was a problem hiding this comment.
How about 복제 instead of Clone?
|
|
||
| ### `venv`를 이용한 가상환경 | ||
|
|
||
| Python의 `venv` 모듈을 사용하여 디렉토리에 가상 환경을 만들 수 있습니다: |
There was a problem hiding this comment.
How about 파이썬 instead of Python?
If you check 자습서 - 사용자 안내서 - 도입부, the word Python is translated as 파이썬.
| $ python -m venv env | ||
| ``` | ||
|
|
||
| 그러면 Python 바이너리를 포함한 `./env/` 디렉토리가 생성되고 그 고립된 환경에 패키지를 설치할 수 있습니다. |
There was a problem hiding this comment.
Same here, 파이썬 instead of Python.
| </div> | ||
| ```` | ||
|
|
||
| 동작 확인을 위해 다음을 실행하십시오: |
There was a problem hiding this comment.
How about 작동하는 걸 확인하기 위해 instead 동작 확인을 위해?
동작 means for living things movement such as human and 작동 means for machines.
|
|
||
| `env/bin/pip` 에 `pip` 바이너리가 나타난다면 제대로 작동하고 있는 것입니다. 🎉 | ||
|
|
||
| !!! tip 이 환경 아래에 `pip` 에서 새 패키지를 설치할 때마다, 가상 환경을 다시 활성화 합니다. |
There was a problem hiding this comment.
I think it would be better to add "팁" right side of tip.
Check #3167 section 파이썬 공식 한국어 문서에 없는 용어 중 현재 사용하고 있는 용어.
|
|
||
| 이제 모든 것을 번역할 수 있고, 파일의 저장 상태를 확인할 수 있습니다. | ||
|
|
||
| #### New Language |
There was a problem hiding this comment.
The header was not translated yet.
|
|
||
| 그 후 "기존의 언어"에 대한 이전의 지시를 계속할 수 있습니다. | ||
|
|
||
| ##### New Language not supported |
There was a problem hiding this comment.
The header was not translated yet.
|
|
||
| 그 후 라이브 서버를 다시 시작합니다. | ||
|
|
||
| #### Preview the result |
There was a problem hiding this comment.
The header was not translated yet.
| Serving at: http://127.0.0.1:8008 | ||
| ``` | ||
|
|
||
| ## Tests |
There was a problem hiding this comment.
The header was not translated yet.
|
|
||
| ### Flit | ||
|
|
||
| **FastAPI** 는 [Flit](https://flit.readthedocs.io/en/latest/index.html) 을 사용하여 프로젝트를 빌드, 패키지, publish합니다. |
There was a problem hiding this comment.
How about 공개 instead of publish?
Because in the context, this (FastAPI) is the open source project so it is open to public by publish the project.
tiangolo
changed the title
docs/ko/docs/contributing.md
tiangolo
added
awaiting-review
lang-all
|
As this PR had requested changes to be applied but has been inactive for a while, it's now going to be closed. But if there's anyone interested, feel free to create a new PR. |
This PR translates contribuing.md in Korean.
I understand it as a request to divide a branch, and divide the Branch and post a PR again.
Thank You, I look forward to your feedback.
related: #2017