[Stopwatch] Add type-hints for Stopwatch and Section classes #32242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
requested changes
Jun 28, 2019
57 tasks
jschaedl
commented
Jun 29, 2019
derrabus
reviewed
Jul 3, 2019
fabpot
requested changes
Jul 5, 2019
jschaedl
force-pushed
the
improvement/stopwatch_type-hints
branch
from
33a3ff1
to
725bad3
Compare
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
…hod. (jschaedl) This PR was merged into the 4.4 branch. Discussion ---------- [Stopwatch] Deprecate passing null in Section::get() method. | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179<!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A This PR is related to #32242 Commits ------- ea48176 [Stopwatch] Deprecate passing null in Section::get() method.
jschaedl
force-pushed
the
improvement/stopwatch_type-hints
branch
from
720af19
to
13f95a6
Compare
Tobion
requested changes
Jul 8, 2019
kaznovac
reviewed
Jul 11, 2019
|
@jschaedl Can you have a look at the remaining comments? Thank you. |
Tobion
force-pushed
the
improvement/stopwatch_type-hints
branch
2 times, most recently
from
481f71d
to
e7426ca
Compare
|
I rebased and fixed the comments. It seems the webprofiler toolbar request does not have the x-debug-token and called the stopwatch needlessly. I skipped it in this case and checked the symfony timeline panel and nothing changed. So this seems fine. |
Tobion
approved these changes
Jul 28, 2019
This was referenced Jul 28, 2019
Tobion
added a commit
that referenced
this pull request
Jul 29, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Stopwatch] fix some phpdocs | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | Fix phpdocs found in #32242 Commits ------- 66dc906 [Stopwatch] fix some phpdocs
Tobion
added a commit
that referenced
this pull request
Jul 29, 2019
…sabled (Tobion) This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] do not stopwatch sections when profiler is disabled | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | the toolbar and profiler panel disable to profiler which then does not set the X-Debug-Token. so when the header does not exist, do not call the stopwatch methods with `null` which violates the contract and does not make sense. found with #32242 Commits ------- 8718cd1 [HttpKernel] do not stopwatch sections when profiler is disabled
Tobion
force-pushed
the
improvement/stopwatch_type-hints
branch
from
e7426ca
to
538cc34
Compare
|
Thank you @jschaedl. |
Tobion
added a commit
that referenced
this pull request
Jul 29, 2019
…sses (jschaedl, Tobion) This PR was merged into the 5.0-dev branch. Discussion ---------- [Stopwatch] Add type-hints for Stopwatch and Section classes | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A <!-- required for new features --> This PR adds type hints to the `Stopwatch` and `Section` classes. Commits ------- 538cc34 [Stopwatch] fix wrong nullable type ff4528e [Stopwatch] Add type-hints for Stopwatch and Section classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds type hints to the
StopwatchandSectionclasses.