[Stopwatch] Deprecate passing null in Section::get() method. #32408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
requested changes
Jul 8, 2019
| @@ -62,6 +62,10 @@ public function __construct(float $origin = null, bool $morePrecision = false) | |||
| */ | |||
| public function get($id) | |||
| { | |||
| if (null === $id) { | |||
| @trigger_error(sprintf('Passing null as 1st ("$id") argument of the "%s()" method is deprecated since Symfony 4.4, pass a valid child section identifier instead.', __METHOD__), E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
Passing "null" as the first argument of the ...
|
Thank you @jschaedl. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
…hod. (jschaedl) This PR was merged into the 4.4 branch. Discussion ---------- [Stopwatch] Deprecate passing null in Section::get() method. | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179<!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A This PR is related to #32242 Commits ------- ea48176 [Stopwatch] Deprecate passing null in Section::get() method.
|
This seems to be incomplete: Fixed in #32428 |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Stopwatch] Fix missing deprecations | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | no needed Fix #32408 Commits ------- 527bf89 Fix missing deprecations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #32242