remove deprecated features #32531
Merged
remove deprecated features #32531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jul 13, 2019
xabbuh
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
xabbuh
force-pushed
the
remove-deprecated-features
branch
3 times, most recently
from
1f54316
to
f4932b5
Compare
xabbuh
force-pushed
the
remove-deprecated-features
branch
from
f4932b5
to
f2b8329
Compare
fabpot
requested changes
Jul 15, 2019
| @@ -62,10 +62,6 @@ public function __construct(float $origin = null, bool $morePrecision = false) | |||
| */ | |||
| public function get($id) | |||
| { | |||
| if (null === $id) { | |||
There was a problem hiding this comment.
Can we add the string type hint on $id?
fabpot
approved these changes
Jul 15, 2019
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jul 15, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- remove deprecated features | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- f2b8329 remove deprecated features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.