[Hackday][Serializer] Deserialization ignores argument type hint from phpdoc for array in constructor argument #29513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
#SymfonyConHackday2018 |
dunglas
approved these changes
Dec 8, 2018
fabpot
approved these changes
Dec 10, 2018
… phpdoc for array in constructor argument
fabpot
force-pushed
the
3.4-deserialize-nested-array-of-objects-bug
branch
from
f552109
to
8741d00
Compare
|
Thank you @karser. |
fabpot
added a commit
that referenced
this pull request
Dec 10, 2018
…e hint from phpdoc for array in constructor argument (karser) This PR was squashed before being merged into the 3.4 branch (closes #29513). Discussion ---------- [Hackday][Serializer] Deserialization ignores argument type hint from phpdoc for array in constructor argument | Q | A | ------------- | --- | Branch? | 3.4 and up to 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28825 | License | MIT This is a fix of #28825 big thanks @dunglas and @xabbuh Commits ------- 8741d00 [Hackday][Serializer] Deserialization ignores argument type hint from phpdoc for array in constructor argument
This was referenced Jan 6, 2019
Merged
Merged
Merged
sandergo90
pushed a commit
to sandergo90/symfony
that referenced
this pull request
Jul 4, 2019
…ent type hint from phpdoc for array in constructor argument (karser) This PR was squashed before being merged into the 3.4 branch (closes symfony#29513). Discussion ---------- [Hackday][Serializer] Deserialization ignores argument type hint from phpdoc for array in constructor argument | Q | A | ------------- | --- | Branch? | 3.4 and up to 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#28825 | License | MIT This is a fix of symfony#28825 big thanks @dunglas and @xabbuh Commits ------- 8741d00 [Hackday][Serializer] Deserialization ignores argument type hint from phpdoc for array in constructor argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix of #28825 big thanks @dunglas and @xabbuh