Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please remove this PR #29507

Closed

Conversation

karser
Copy link
Contributor

@karser karser commented Dec 7, 2018

Q A
Branch? 3.4 and up to 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #28825
License MIT

Hello @dunglas and @xabbuh looks like you guys were working on Serializer closely
This is a reproducer of #28825
I think something goes wrong in AbstractNormalizer::instantiateObject

We can discuss this issue on Hackday tomorrow

image

@karser karser changed the base branch from master to 3.4 December 7, 2018 23:06
@karser karser changed the base branch from 3.4 to master December 7, 2018 23:07
@karser karser changed the title [Serializer] Deserialization ignores argument type hint from phpdoc for array in constructor argument [Hackday][Serializer] Deserialization ignores argument type hint from phpdoc for array in constructor argument Dec 8, 2018
@karser karser changed the title [Hackday][Serializer] Deserialization ignores argument type hint from phpdoc for array in constructor argument please remove this PR Dec 8, 2018
@xabbuh
Copy link
Member

xabbuh commented Dec 8, 2018

Thank you 👍 closing here in favour of #29513

@xabbuh xabbuh closed this Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants