[Serializer] Allow denormalization of constructor arguments to array of objects

[cezarystepkowski]

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#25524
License	MIT
Doc PR	todo

Currently it is not possible to denormalize array of objects passed to the class constructor as described in the issue #25524. When instantiating an object if constructor parameter is of array type its value is being set as it is without any further denormalization.

This pull request handles it by providing this further denormalization in the same way like it is currently done for non-constructor parameters. It means that now the constructor parameter type can be read from the php doc annotation and if it is an array of objects it will be denormalized correctly.

[dunglas]

Shouldn't this be implemented directly in the PropertyInfo component just as it was done for parsing types using the reflection API in #25605?

[cezarystepkowski]

@dunglas I think the answer to your question is here: #25524 (comment)

Maybe it's not super clear from the diff but I barely introduced any new logic with this pull request.
The only change was to abstract parsing of constructor parameter in AbstractNormalizer into protected method so that it can be overridden in AbstractObjectNormalizer so that AbstractObjectNormalizer can call validateAndDenormalize for arrays. validateAndDenormalize already parses the array of objects correctly.

[dunglas]

@cezarystepkowski it makes sense. As we try to avoid the proliferation of such methods in the abstract classes, can you mark them @internal?

[cezarystepkowski]

@dunglas I marked the methods as internal. Additionally, I rebased onto current master.

[ragboyjr]

@cezarystepkowski what is the status of this? This change is awesome and would definitely be a huge improvement.

[cezarystepkowski]

@ragboyjr I rebased onto current master and resolved conflicts.

@dunglas All tests inside serializer component are passing. The coding standards failure is not caused by changes in this PR so I left it failing (I can fix it of course if needed). Is there anything else needed?

[cezarystepkowski]

@nicolas-grekas both suggested changes applied.

[nicolas-grekas]

Thanks. Would you mind rebasing please (and squashing meanwhile if you want)? We don't merge PRs that have merge commits.

[cezarystepkowski]

@nicolas-grekas rebased and squashed :)

[ogizanagi]

A new entry is missing from src/Symfony/Component/Serializer/CHANGELOG.md to mention this feature :)

[cezarystepkowski]

@ogizanagi I updated the changelog, as version 4.2.0 is already released, I've added the entry for 4.3.0. If it's not correct please let me know how should it be :)

[cezarystepkowski]

I am closing this PR as the same functionality has been already merged here: #29513