[HttpFoundation] Allow set 'None' on samesite cookie flag #31475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow set samesite cookie flag to 'None' value
markitosgv
changed the title
nicolas-grekas
approved these changes
May 11, 2019
fabpot
approved these changes
May 11, 2019
|
Thank you @markitosgv. |
nicolas-grekas
added a commit
that referenced
this pull request
May 11, 2019
…(markitosgv) This PR was merged into the 3.4 branch. Discussion ---------- [HttpFoundation] Allow set 'None' on samesite cookie flag Allow set samesite cookie flag to 'None' value | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31467 | License | MIT Google introduces new Chrome policy, marking all none setted samesite flag to 'Strict' by default. If you want to allow third party cookies you must set samesite flag to None. This PR fixes #31467, allow to put samesite Cookie flag to None. Commits ------- 8bac3d6 Allow set 'None' on samesite cookie flag
This was referenced May 22, 2019
Merged
Merged
Merged
MKodde
added a commit
to OpenConext/Stepup-Azure-MFA
that referenced
this pull request
Mar 10, 2020
The php session cookie should not have the samesite lax or strict setting. As this would prevent the session cookie from being present when the remote azure mfa idp sends back a SAML response. So it is set to the for now advisable 'none' setting. Combined with the secure setting, this will be accepted by modern browsers. See: https://www.pivotaltracker.com/story/show/171721565 symfony/symfony#31475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow set samesite cookie flag to 'None' value
Google introduces new Chrome policy, marking all none setted samesite flag to 'Strict' by default. If you want to allow third party cookies you must set samesite flag to None.
This PR fixes #31467, allow to put samesite Cookie flag to None.