Disable SameSite setting for session cookies #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The php session cookie should not have the samesite lax or strict setting. As this would prevent the session cookie from being present when the remote azure mfa idp sends back a SAML response. So it is set to the for now advisable 'none' setting. Combined with the secure setting, this will be accepted by modern browsers. See: https://www.pivotaltracker.com/story/show/171721565 symfony/symfony#31475
MKodde
force-pushed
the
feature/disable-same-site-directive
branch
from
e5ba28c
to
6000af5
Compare
|
The build is breaking because of 'some' JS dependencies with security issues. This is addressed in #23 |
pablothedude
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHP session cookie should not have the samesite lax or strict setting. As this would prevent the session cookie from being present when the remote Azure MFA IdP sends back a SAML response.
So it is set to the for now advisable 'none' setting. Combined with the secure setting, this will be accepted by modern browsers.
See:
https://www.pivotaltracker.com/story/show/171721565
symfony/symfony#31475