Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Add "none" to supported same site options in session config #5174

Merged

Conversation

bertheyman
Copy link
Contributor

The cookie functionality is built on the one from Symfony, which lacked support for "same-site: none" until a coupe of months ago.

In some cases, Chrome might block cookie access for both strict and lax, so would be imported to know that "none" is supported too.

⚠️ When using same-site: none, Chrome also needs secure to be set to true. Does this need to be mentioned as well?

Symfony PR: symfony/symfony#31475

@driesvints driesvints changed the title Add "none" to supported same site options in session config [6.x] Add "none" to supported same site options in session config Dec 13, 2019
@taylorotwell taylorotwell merged commit 136085b into laravel:master Dec 13, 2019
socheatsok78 pushed a commit to pp-spaces/laravel that referenced this pull request Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants