Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SameSite cookie option could not be set to "none" #33926

Closed
ihmels opened this issue Oct 9, 2019 · 0 comments
Closed

SameSite cookie option could not be set to "none" #33926

ihmels opened this issue Oct 9, 2019 · 0 comments
Labels
Bug FrameworkBundle SecurityBundle Status: Needs Review

Comments

@ihmels
Copy link
Contributor

ihmels commented Oct 9, 2019

Symfony version(s) affected: 4.3.*

Description
The PR #31475 allows to set the samesite cookie flag to "none", but it is not allowed in the framework.session.cookie_samesite or remember_me.samesite config.

How to reproduce

# framework.yml
framework:
    session:
        cookie_samesite: 'none'

# or packages/security.yml
security:
    firewalls:
        main:
            remember_me:
              samesite: 'none'

Additional context

The value "none" is not allowed for path "framework.session.cookie_samesite".
Permissible values: null, "lax", "strict"
@ihmels ihmels mentioned this issue Oct 9, 2019
Merged
nicolas-grekas added a commit that referenced this issue Oct 9, 2019
@nicolas-grekas
bug #33927 Allow to set SameSite config to 'none' (ihmels)
ac422db 
This PR was merged into the 4.3 branch.

Discussion
----------

Allow to set SameSite config to 'none'

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #33926
| License       | MIT
| Doc PR        | -

Commits
-------

eec7e8c Allow to set cookie_samesite to 'none'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug FrameworkBundle SecurityBundle Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@javiereguiluz @nicolas-grekas @ihmels @carsonbot