Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand goreleaser Build Architectures #183

Merged
merged 2 commits into from Mar 9, 2022
Merged

Expand goreleaser Build Architectures #183

merged 2 commits into from Mar 9, 2022

Conversation

tri-adam
Copy link
Member

@tri-adam tri-adam commented Mar 9, 2022

Extend goreleaser configuration to build for all Linux architectures supported by siftool. Simplify goreleaser configuration, and split out darwin and linux builds separately.

@tri-adam tri-adam self-assigned this Mar 9, 2022
@tri-adam tri-adam changed the title Refactor goreleaser Configuration Expand goreleaser Build Architectures Mar 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #183 (e48e4f8) into master (2378e6b) will decrease coverage by 0.04%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   76.51%   76.46%   -0.05%     
==========================================
  Files          28       28              
  Lines        2499     2503       +4     
==========================================
+ Hits         1912     1914       +2     
- Misses        448      450       +2     
  Partials      139      139              
Impacted Files Coverage Δ
pkg/siftool/add.go 52.90% <33.33%> (-0.63%) ⬇️
pkg/sif/arch.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2378e6b...e48e4f8. Read the comment docs.

@tri-adam tri-adam marked this pull request as ready for review March 9, 2022 16:26
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@tri-adam tri-adam merged commit 3b17b93 into sylabs:master Mar 9, 2022
@tri-adam tri-adam deleted the goreleaser branch March 9, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants