Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sylabs/sif through v2.4.0 #130

Merged
merged 4 commits into from Mar 11, 2022
Merged

Conversation

edytuk
Copy link
Contributor

@edytuk edytuk commented Mar 10, 2022

This pulls in the following PRs, bringing apptainer/sif up to the level of v2.4.0

Adam Hughes added 3 commits March 10, 2022 14:53
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #130 (00ebaa3) into master (7af6527) will decrease coverage by 0.04%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   76.51%   76.46%   -0.05%     
==========================================
  Files          28       28              
  Lines        2499     2503       +4     
==========================================
+ Hits         1912     1914       +2     
- Misses        448      450       +2     
  Partials      139      139              
Flag Coverage Δ
unittests 76.46% <60.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/siftool/add.go 52.90% <33.33%> (-0.63%) ⬇️
pkg/sif/arch.go 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@DrDaveD DrDaveD merged commit 4c6ea58 into apptainer:master Mar 11, 2022
@edytuk edytuk deleted the sylabsv2.4.0 branch March 11, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants