Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sylabs/sif through v2.4.0 #7

Closed
wants to merge 3 commits into from
Closed

Merge sylabs/sif through v2.4.0 #7

wants to merge 3 commits into from

Conversation

edytuk
Copy link
Owner

@edytuk edytuk commented Mar 10, 2022

This pulls in the following PRs, bringing apptainer/sif up to the level of v2.4.0

Adam Hughes added 3 commits March 10, 2022 14:53
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
@codecov-commenter
Copy link

Codecov Report

Merging #7 (ddaa9df) into master (0fcb0ac) will decrease coverage by 0.04%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   76.51%   76.46%   -0.05%     
==========================================
  Files          28       28              
  Lines        2499     2503       +4     
==========================================
+ Hits         1912     1914       +2     
- Misses        448      450       +2     
  Partials      139      139              
Flag Coverage Δ
unittests 76.46% <60.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/siftool/add.go 52.90% <33.33%> (-0.63%) ⬇️
pkg/sif/arch.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fcb0ac...ddaa9df. Read the comment docs.

@edytuk edytuk requested a review from DrDaveD March 10, 2022 14:06
@edytuk edytuk closed this Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants