Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RISC-V Architecture #182

Merged
merged 1 commit into from Mar 9, 2022
Merged

Add RISC-V Architecture #182

merged 1 commit into from Mar 9, 2022

Conversation

tri-adam
Copy link
Member

@tri-adam tri-adam commented Mar 8, 2022

Add riscv64 architecture to archType mapping functions. Add corresponding option to --partarch flag of add command.

Closes #181

@tri-adam tri-adam self-assigned this Mar 8, 2022
@tri-adam tri-adam marked this pull request as ready for review March 8, 2022 23:31
@codecov-commenter
Copy link

Codecov Report

Merging #182 (474691f) into master (2378e6b) will decrease coverage by 0.04%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
- Coverage   76.51%   76.46%   -0.05%     
==========================================
  Files          28       28              
  Lines        2499     2503       +4     
==========================================
+ Hits         1912     1914       +2     
- Misses        448      450       +2     
  Partials      139      139              
Impacted Files Coverage Δ
pkg/siftool/add.go 52.90% <33.33%> (-0.63%) ⬇️
pkg/sif/arch.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2378e6b...474691f. Read the comment docs.

Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - will leave it unmerged for a bit pending feedback? I can try with qemu later this week, or early next week if needed.

@tri-adam
Copy link
Member Author

tri-adam commented Mar 9, 2022

LGTM - will leave it unmerged for a bit pending feedback? I can try with qemu later this week, or early next week if needed.

I think that's wise, yeah.

@jorgee
Copy link

jorgee commented Mar 9, 2022

I tested this branch with the 3.9.5 released in an RISC-V 64bits Unmatched board with ubuntu linux and it is working. Still appearing a message "Architecture not recognized, use native" but not failing as before.

Steps I have done

1.- cloned repo tri-adam:riscv64 in /home/myuser/sif-riscv64
2.- download and untar singularity-3.9.5.tar.gz
3.- in singularity-3.9.5/go.mod add "replace github.com/sylabs/sif/v2 => /home/myuser/sif-riscv64"
4.- go mod tidy
5.- go mod vendor
6.- Install singularity ./mconfig ...

@dtrudg
Copy link
Member

dtrudg commented Mar 9, 2022

"Architecture not recognized, use native"

... is related to SingularityCE's code, not SIF. Opened sylabs/singularity#628 to track that once an updated SIF is pulled into SingularityCE.

Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed 🎉

@tri-adam tri-adam merged commit b967dd3 into sylabs:master Mar 9, 2022
@tri-adam tri-adam deleted the riscv64 branch March 9, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RISC-V Support
4 participants