New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RISC-V Architecture #182
Conversation
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
- Coverage 76.51% 76.46% -0.05%
==========================================
Files 28 28
Lines 2499 2503 +4
==========================================
+ Hits 1912 1914 +2
- Misses 448 450 +2
Partials 139 139
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - will leave it unmerged for a bit pending feedback? I can try with qemu later this week, or early next week if needed.
I think that's wise, yeah. |
I tested this branch with the 3.9.5 released in an RISC-V 64bits Unmatched board with ubuntu linux and it is working. Still appearing a message "Architecture not recognized, use native" but not failing as before. Steps I have done 1.- cloned repo tri-adam:riscv64 in /home/myuser/sif-riscv64 |
... is related to SingularityCE's code, not SIF. Opened sylabs/singularity#628 to track that once an updated SIF is pulled into SingularityCE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed 🎉
Add
riscv64
architecture toarchType
mapping functions. Add corresponding option to--partarch
flag ofadd
command.Closes #181