Refactor to turn on noUncheckedIndexedAccess option for TypeScript
#5983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybiquitous
commented
Apr 19, 2022
| @@ -117,7 +117,7 @@ function longer(hex) { | |||
| let hexVariant = '#'; | |||
|
|
|||
| for (let i = 1; i < hex.length; i++) { | |||
| hexVariant += hex[i] + hex[i]; | |||
| hexVariant += hex.charAt(i).repeat(2); | |||
There was a problem hiding this comment.
[note] .charAt() always returns a string (e.g. an empty string).
ybiquitous
commented
Apr 19, 2022
| for (let i = 0; i < lines.length; i++) { | ||
| let line = lines[i]; | ||
|
|
||
| for (let [i, line] of lines.entries()) { |
There was a problem hiding this comment.
[note] .entries() makes a traditional for loop much readable.
ybiquitous
commented
Apr 19, 2022
| @@ -110,16 +110,20 @@ const rule = (primary, secondaryOptions) => { | |||
| * @returns {boolean} | |||
| */ | |||
| function hasInterpolatingAmpersand(selector) { | |||
| for (let i = 0, l = selector.length; i < l; i++) { | |||
| if (selector[i] !== '&') { | |||
| for (const [i, char] of Array.from(selector).entries()) { | |||
There was a problem hiding this comment.
[note] Array.from() can make a string to an array of characters.
|
The CI is now all green. ✅ |
jeddy3
changed the title
noUncheckedIndexedAccess option for TypeScriptnoUncheckedIndexedAccess option for TypeScript
jeddy3
approved these changes
Apr 19, 2022
|
@jeddy3 Thank you for reviewing the big pull request! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.typescriptlang.org/tsconfig#noUncheckedIndexedAccess
Ref: #5982 (comment)
The
noUncheckedIndexedAccessoption allows us to detect potential bugs like #5982, e.g.Note: This pull request just helps us to see the errors if
noUncheckedIndexedAccessis turned on. We cannot merge it now.See https://www.typescriptlang.org/tsconfig#noUncheckedIndexedAccess
EDIT: If you want to try it on a branch other than this one, you can use the CLI flag
--noUncheckedIndexedAccess, for example:$ npm run lint:types -- --noUncheckedIndexedAccess