Refactor to improve types for lib/assignDisabledRanges.js
#6014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change aims to fix errors by the TypeScript compiler option `noUncheckedIndexedAccess`.
ybiquitous
commented
Apr 15, 2022
| @@ -259,18 +263,10 @@ module.exports = function assignDisabledRanges(root, result) { | |||
|
|
|||
| if (ruleIsDisabled(ALL_RULES) && disabledRanges[ruleToEnable] === undefined) { | |||
| // Get a starting point from the where all rules were disabled | |||
| if (!disabledRanges[ruleToEnable]) { | |||
There was a problem hiding this comment.
[note] If ruleIsDisabled(ALL_RULES) && disabledRanges[ruleToEnable] === undefined is true, !disabledRanges[ruleToEnable] should always be true. So, the else block should never be executed.
|
@jeddy3 Thank you for the review. 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #5983
This change aims to:
noUncheckedIndexedAccess