Refactor to improve types for validateTypes and whitespaceChecker
#6002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybiquitous
commented
Mar 31, 2022
| ) { | ||
| return; | ||
| } | ||
|
|
||
| assertFunction(messageFunc); | ||
| activeArgs.err(messageFunc(activeArgs.errTarget || source[index])); | ||
| activeArgs.err(messageFunc(activeArgs.errTarget || source.charAt(index))); |
There was a problem hiding this comment.
[note] source[index] can return undefined, while source.charAt(index) always returns a string. See the charAt() doc:
If
indexis out of range,charAt()returns an empty string.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/charAt
I think it safe to use charAt() in this case to build an error message.
|
@jeddy3 Thank you for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5983
This refactoring does the following:
lib/utils/whitespaceChecker.jstolib/utils/validateTypes.jsvalidateTypes.jsvalidateTypes.jswhitespaceChecker.jsvia thenoUncheckedIndexedAccessTypeScript compiler optionWe can see the error resolution via the following commands: