New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false positives for interpolation in function-no-unknown
#5914
Fix false positives for interpolation in function-no-unknown
#5914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m4thieulavoie Thanks for the pull request.
As per #5913 (comment), let's check for #{
in the isStandardSyntaxFunction
utility instead.
You'll want to include the accept tests in this testRule
so that the postcss-scss custom syntax is used.
I suspect the changes you've made in this pull request to sanitize the node value will be useful in the stylelint-scss plugin if they add a scss/function-no-unknown
rule. Let's revert them in this pull request, though.
0ab582d
to
345996e
Compare
apply pr comments
345996e
to
a58f929
Compare
That should be done 👍 Let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m4thieulavoie Thank you. LGTM 👍🏼
function-no-unknown
Updated the changelog:
|
This PR tweaks
function-no-unknown
so thatignoreFunctions
are also supported in the custom properties syntax (e.g.--primary-color: #{custom-mixin(#fff)};
Fixes #5913
e.g. "No, it's self-explanatory."