Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ENOENT and TypeErrors in function-no-unknown #5916

Merged
merged 1 commit into from Feb 15, 2022
Merged

Fix ENOENT and TypeErrors in function-no-unknown #5916

merged 1 commit into from Feb 15, 2022

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Feb 14, 2022 •
edited

Which issue, if any, is this issue related to?

Is there anything in the PR that needs further explanation?

This change bumps css-functions-list from 3.0.0 to 3.0.1.
See https://github.com/niksy/css-functions-list/releases/tag/v3.0.1

npm i css-functions-list

css-functions-list@3.0.1 improves handling paths on Windows. So, it's no longer necessary to use URL in our code.

@ybiquitous
Improve usage of css-functions-list in function-no-unknown
dd650ef 
This change bumps `css-functions-list` from 3.0.0 to 3.0.1.
See https://github.com/niksy/css-functions-list/releases/tag/v3.0.1

```shell
npm i css-functions-list
```
This was referenced Feb 14, 2022
Closed
Closed
jeddy3
jeddy3 approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Thanks also for helping resolve the issue upstream.

What's the impact of the bug btw; is it only affecting Jest test or is it generally affecting all windows users?

@jeddy3 jeddy3 changed the title Improve usage of css-functions-list in function-no-unknown Fix ENOENT and TypeErrors in function-no-unknown Feb 14, 2022
@ybiquitous
Copy link
Member Author

ybiquitous commented Feb 14, 2022 •
edited

What's the impact of the bug btw; is it only affecting Jest test or is it generally affecting all windows users?

Probably, I think this PR will fix problems about ERR_INVALID_URL_SCHEME (#5918) in addition to Jest and Windows.

@jeddy3
Copy link
Member

jeddy3 commented Feb 14, 2022

Good to know. Let's release when #5914 lands so that we shore up the new rule.

@ybiquitous ybiquitous mentioned this pull request Feb 14, 2022
Merged
@niksy
Copy link

niksy commented Feb 14, 2022 •
edited

Sorry this produced errors, but I’ve been following proper way on how to handle __dirname in ESM so I guess this should cover it. Could it be it’s related only to how Jest handles imports? It’s strange that native feature of modern Node doesn’t work for this simple use case.

@jeddy3
Copy link
Member

jeddy3 commented Feb 15, 2022

Is there more to do on this issue or can we merge?

@jeddy3 jeddy3 mentioned this pull request Feb 15, 2022
Closed
6 tasks
@ybiquitous ybiquitous merged commit 1496df3 into main Feb 15, 2022
@ybiquitous ybiquitous deleted the bump-css-functions-list branch February 15, 2022 23:17
@ybiquitous
Copy link
Member Author

I forgot the merge. 😅

@ybiquitous
Copy link
Member Author

Updated the changelog:

Fixed: function-no-unknown ENOENT and TypeErrors (#5916).

@sync-by-unito sync-by-unito bot mentioned this pull request Mar 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request May 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@ybiquitous @jeddy3 @niksy