better handling of function-no-unknown

stylelint · Feb 14, 2022 · 0ab582d · 0ab582d
1 parent 2db2c94
commit 0ab582d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/lib/rules/function-no-unknown/__tests__/index.js b/lib/rules/function-no-unknown/__tests__/index.js
@@ -78,6 +78,9 @@ testRule({
 		{
 			code: 'a { transform: BAR(1px); }',
 		},
+		{
+			code: 'a { --primary-color: #{theme(1px)}; }',
+		},
 	],
 
 	reject: [
@@ -93,5 +96,11 @@ testRule({
 			line: 1,
 			column: 16,
 		},
+		{
+			code: 'a { --primary-color: #{theme-custom(1px)}; }',
+			message: messages.rejected('#{theme-custom'),
+			line: 1,
+			column: 22,
+		},
 	],
 });
diff --git a/lib/rules/function-no-unknown/index.js b/lib/rules/function-no-unknown/index.js
@@ -51,6 +51,8 @@ const rule = (primary, secondaryOptions) => {
 			const { value } = decl;
 
 			valueParser(value).walk((node) => {
+				const sanitizedValue = node.value.replace(/^(#\{)/g, '').replace(/\}/g, '');
+
 				if (node.type !== 'function') {
 					return;
 				}
@@ -59,15 +61,15 @@ const rule = (primary, secondaryOptions) => {
 					return;
 				}
 
-				if (isCustomFunction(node.value)) {
+				if (isCustomFunction(sanitizedValue)) {
 					return;
 				}
 
-				if (optionsMatches(secondaryOptions, 'ignoreFunctions', node.value)) {
+				if (optionsMatches(secondaryOptions, 'ignoreFunctions', sanitizedValue)) {
 					return;
 				}
 
-				if (functionsList.includes(node.value.toLowerCase())) {
+				if (functionsList.includes(sanitizedValue.toLowerCase())) {
 					return;
 				}