Refactor lib/__tests__/standalone-cache.test.js
#5311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reduce redundant callbacks via `async/await` syntax. (#4881) - Use `fs.existsSync()` instead of `fs.access()`. See <https://nodejs.org/api/fs.html#fs_fs_existssync_path> - Fix the disabled test. (#5309) - Inline redundant local variables. - Make expectations using `typeof` more accurate.
Closed
ybiquitous
commented
May 17, 2021
| fs.access(filePath, fsConstants.F_OK).then( | ||
| () => true, | ||
| () => false, | ||
| ); |
There was a problem hiding this comment.
[note] I think it simple and enough to use fs.existsSync() for tests.
ybiquitous
commented
May 17, 2021
| }); | ||
| // Ensure cache file contains only linted css file | ||
| expect(typeof cache.getKey(validFile)).toBe('object'); | ||
| expect(cache.getKey(validFile)).toBeTruthy(); |
There was a problem hiding this comment.
[note] I've added the expectation .toBeTruthy() because of typeof null === 'object'. But it may be a bit ugly and is not DRY. 🤔
ybiquitous
commented
May 17, 2021
|
|
||
| it("cache doesn't do anything if string is passed", async () => { | ||
| // Ensure no cache file | ||
| await removeFile(expectedCacheFilePath); |
There was a problem hiding this comment.
[note] This addition of removeFile() fixes #5309.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async/awaitsyntax. (Fix tests that use callbacks #4881)fs.existsSync()instead offs.access().See https://nodejs.org/api/fs.html#fs_fs_existssync_path
typeofmore accurate.Fix #5309
A part of #4881
This PR's base branch is
v14.