Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache #5309

Closed
Tracked by #5205
jeddy3 opened this issue May 16, 2021 · 0 comments · Fixed by #5311
Closed
Tracked by #5205

Fix cache #5309

jeddy3 opened this issue May 16, 2021 · 0 comments · Fixed by #5311
Labels
status: ready to implement is ready to be worked on by someone type: bug a problem with a feature or rule
Milestone

Comments

@jeddy3
Copy link
Member

jeddy3 commented May 16, 2021

A test was skipped in #5306 and needs looking into.

// eslint-disable-next-line jest/no-disabled-tests
it.skip("cache doesn't do anything if string is passed", async () => {
const config = {
code: '.foo {}',
codeFilename: 'foo.css',
cache: true,
config: {
rules: {
'color-no-invalid-hex': true,
},
},
};
const lintResults = await standalone(config);
expect(lintResults.errored).toBe(false);
await expect(fileExists(expectedCacheFilePath)).resolves.toBe(false);
});

@jeddy3 jeddy3 added status: ready to implement is ready to be worked on by someone type: bug a problem with a feature or rule labels May 16, 2021
@jeddy3 jeddy3 added this to the future-major milestone May 16, 2021
@jeddy3 jeddy3 mentioned this issue May 16, 2021
30 tasks
ybiquitous added a commit that referenced this issue May 17, 2021
- Reduce redundant callbacks via `async/await` syntax. (#4881)
- Use `fs.existsSync()` instead of `fs.access()`.
  See <https://nodejs.org/api/fs.html#fs_fs_existssync_path>
- Fix the disabled test. (#5309)
- Inline redundant local variables.
- Make expectations using `typeof` more accurate.
@ybiquitous ybiquitous linked a pull request May 17, 2021 that will close this issue
jeddy3 pushed a commit that referenced this issue May 17, 2021
* Refactor `lib/__tests__/standalone-cache.test.js`

- Reduce redundant callbacks via `async/await` syntax. (#4881)
- Use `fs.existsSync()` instead of `fs.access()`.
  See <https://nodejs.org/api/fs.html#fs_fs_existssync_path>
- Fix the disabled test. (#5309)
- Inline redundant local variables.
- Make expectations using `typeof` more accurate.

* Reduce local variables by improving `getConfig()`
@jeddy3 jeddy3 closed this as completed May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready to implement is ready to be worked on by someone type: bug a problem with a feature or rule
Development

Successfully merging a pull request may close this issue.

1 participant