Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lib/__tests__/standalone-cache.test.js #5311

Merged
merged 2 commits into from
May 17, 2021
Merged

Refactor lib/__tests__/standalone-cache.test.js #5311

merged 2 commits into from
May 17, 2021

Commits on May 17, 2021

  1. Refactor lib/__tests__/standalone-cache.test.js 

    - Reduce redundant callbacks via `async/await` syntax. (#4881)
- Use `fs.existsSync()` instead of `fs.access()`.
  See <https://nodejs.org/api/fs.html#fs_fs_existssync_path>
- Fix the disabled test. (#5309)
- Inline redundant local variables.
- Make expectations using `typeof` more accurate.
    @ybiquitous
    ybiquitous committed May 17, 2021
    Configuration menu
    Copy the full SHA
    5ba7f06 View commit details
    Browse the repository at this point in the history

  2. Reduce local variables by improving getConfig()

    @ybiquitous
    ybiquitous committed May 17, 2021
    Configuration menu
    Copy the full SHA
    6373792 View commit details
    Browse the repository at this point in the history