png as default favicon to allow alpha transparency #4272
Conversation
There was a problem hiding this comment.
Thanks for the contribution @rbeauchemin!
I'll need to double-check with the team to make sure that there wasn't a specific reason we set the favicon output format to jpeg. This is just me being paranoid, though, and we most likely just chose an arbitrary default when writing this code.
I'll get back to you in a day or two once I've double-checked!
| @@ -104,7 +104,7 @@ def set_page_config( | |||
| width=-1, # Always use full width for favicons | |||
| clamp=False, | |||
| channels="RGB", | |||
| output_format="JPEG", | |||
| output_format="PNG", | |||
There was a problem hiding this comment.
Hm, I think we may want to set output_format="auto" here, which should normally do a conversion to JPEG, but will keep the image as a PNG if it could have an alpha channel
There was a problem hiding this comment.
Thank you for the suggestion. I tested "auto" locally and it does work as expected!
There was a problem hiding this comment.
updated to your suggestion in 1280b7b
with ouptut_formatter set to auto
There was a problem hiding this comment.
馃帀 thanks for making the updates, @rbeauchemin!
We couldn't remember any reason that we chose to always convert favicons to JPEG internally, so I think it's safe to assume that it was an arbitrary choice made when implementing this feature.
This change should land when v1.5 is released in ~2 weeks.
Sounds good @vdonato. BTW I like your profile pic haha |
馃摎 Context
I wanted to have my custom logo as the favicon for my streamlit app, and it loaded in but the transparent parts were filled with a random color. This change makes the default type PNG, a type that allows for alpha transparency and is supported by common browsers (https://caniuse.com/link-icon-png).
What kind of change does this PR introduce?
馃 Description of Changes
Changed type to PNG from JPEG for custom, non-emoji favicons
Revised:
Pretty transparent favicon!
Current:
Favicon with extra blue stuff around it (alpha filled from common color)
馃И Testing Done
馃寪 References
This PR has no dependencies.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.