Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep support for ICO formats by defaulting to PNG if necessary #4340

Closed
wants to merge 3 commits into from

Conversation

kmcgrady
Copy link
Collaborator

馃摎 Context

Please describe the project or issue background here

  • What kind of change does this PR introduce?

    • Bugfix

馃 Description of Changes

  • We introduced an issue in png as default favicon to allow alpha transparency聽#4272 that made Streamlit decide the best format.
  • This fails at "unrecognized formats", namely an ICO format for the page icon
    • An unrecognized format is one that is understood by Pillow but not by imghdr
  • It should be noted that any unrecognized formats would fail as well, and we should be more resilient
  • The change suggests that if imghdr cannot determine the image, aim for the default mimetype as defined by "auto".

No screenshot needed

馃И Testing Done

  • Added/Updated e2e tests

馃寪 References

Does this depend on other work, documents, or tickets?


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@kmcgrady kmcgrady closed this Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICO formats fail on set_page_config page icons
1 participant