Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

png as default favicon to allow alpha transparency #4272

Merged
merged 2 commits into from Jan 14, 2022
Merged

png as default favicon to allow alpha transparency #4272

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e955c2
png as default favicon to allow alpha transparency
Jan 12, 2022
1280b7b
allow alpha transparency in favicon
rbeauchemin Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/streamlit/commands/page_config.py
View file
Open in desktop
Expand Up @@ -104,7 +104,7 @@ def set_page_config(
width=-1, # Always use full width for favicons
clamp=False,
channels="RGB",
output_format="JPEG",
output_format="PNG",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I think we may want to set output_format="auto" here, which should normally do a conversion to JPEG, but will keep the image as a PNG if it could have an alpha channel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestion. I tested "auto" locally and it does work as expected!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to your suggestion in 1280b7b

image_id="favicon",
allow_emoji=True,
)
Expand Down