Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix IE11 compatibility by using XHR and plain ES5 #13348

Merged
merged 4 commits into from Dec 3, 2020
Merged

Core: Fix IE11 compatibility by using XHR and plain ES5 #13348

merged 4 commits into from Dec 3, 2020

Conversation

ghengeveld
Copy link
Member

Issue: #13314

What I did

This fixes IE11 by using XMLHttpRequest instead of fetch and avoiding the ES6 object shorthand syntax in the runtime error reporting code.

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes, Chromatic should have picked up the IE11 breakage
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

shilman
shilman requested changes Dec 1, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back to the drawing board buddy ... 😜

lib/core/src/server/templates/base-manager-head.html Outdated Show resolved Hide resolved
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Dec 3, 2020
shilman
shilman approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@shilman shilman merged commit 2a46f0d into next Dec 3, 2020
@shilman shilman deleted the 13314-ie11-runtime-errors branch December 3, 2020 00:29
@shilman shilman mentioned this pull request Dec 3, 2020
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

@aaronmcadam aaronmcadam Awaiting requested review from aaronmcadam

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

@CodeByAlex CodeByAlex Awaiting requested review from CodeByAlex

@dangreenisrael dangreenisrael Awaiting requested review from dangreenisrael

@jbovenschen jbovenschen Awaiting requested review from jbovenschen

@kazupon kazupon Awaiting requested review from kazupon

@leonrodenburg leonrodenburg Awaiting requested review from leonrodenburg

@thani-sh thani-sh Awaiting requested review from thani-sh

@renaudtertrais renaudtertrais Awaiting requested review from renaudtertrais

@saponifi3d saponifi3d Awaiting requested review from saponifi3d

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal

@theinterned theinterned Awaiting requested review from theinterned

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

@z4o4z z4o4z Awaiting requested review from z4o4z

Assignees

@shilman shilman

@ndelangen ndelangen

Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ghengeveld @shilman @ndelangen