Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix IE11 compatibility by using XHR and plain ES5 #13348

Merged
merged 4 commits into from Dec 3, 2020
Merged

Core: Fix IE11 compatibility by using XHR and plain ES5 #13348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4112b32
Fix IE11 compatibility by avoiding ES6 syntax and using XHR instead o…
ghengeveld Dec 1, 2020
4878bb9
err can be undefined.
ghengeveld Dec 1, 2020
f627d23
Merge branch 'next' into 13314-ie11-runtime-errors
ghengeveld Dec 1, 2020
90871c0
Merge branch 'next' into 13314-ie11-runtime-errors
shilman Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/core/src/server/dev-server.ts
View file
Open in desktop
Expand Up @@ -283,9 +283,9 @@ const startManager = async ({

// Used to report back any client-side (runtime) errors
router.post('/runtime-error', express.json(), (request, response) => {
if (request.body?.error) {
if (request.body?.error || request.body?.message) {
logger.error('Runtime error! Check your browser console.');
logger.error(request.body.error.stack || request.body.message || request.body);
logger.error(request.body.error?.stack || request.body.message || request.body);
if (request.body.origin === 'manager') clearManagerCache(options.cache);
}
response.sendStatus(200);
Expand Down
22 changes: 15 additions & 7 deletions lib/core/src/server/templates/base-manager-head.html
View file
Open in desktop
Expand Up @@ -27,12 +27,20 @@
window.onerror = function onerror(message, source, line, column, err) {
if (window.CONFIG_TYPE !== 'DEVELOPMENT') return;
// eslint-disable-next-line no-var, vars-on-top
var error = err ? { message: err.message, name: err.name, stack: err.stack } : {};
window.fetch('/runtime-error', {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
// eslint-disable-next-line object-shorthand, prettier/prettier
body: JSON.stringify({ message: message, source: source, line: line, column: column, error: error, origin: 'manager' }),
});
var xhr = new window.XMLHttpRequest();
xhr.open('POST', '/runtime-error');
xhr.setRequestHeader('Content-Type', 'application/json;charset=UTF-8');
xhr.send(
JSON.stringify({
/* eslint-disable object-shorthand */
message: message,
source: source,
line: line,
column: column,
error: err && { message: err.message, name: err.name, stack: err.stack },
origin: 'manager',
/* eslint-enable object-shorthand */
})
);
};
</script>
22 changes: 15 additions & 7 deletions lib/core/src/server/templates/base-preview-head.html
View file
Open in desktop
Expand Up @@ -115,12 +115,20 @@
window.onerror = function onerror(message, source, line, column, err) {
if (window.CONFIG_TYPE !== 'DEVELOPMENT') return;
// eslint-disable-next-line no-var, vars-on-top
var error = err ? { message: err.message, name: err.name, stack: err.stack } : {};
window.fetch('/runtime-error', {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
// eslint-disable-next-line object-shorthand, prettier/prettier
body: JSON.stringify({ message: message, source: source, line: line, column: column, error: error, origin: 'preview' }),
});
var xhr = new window.XMLHttpRequest();
xhr.open('POST', '/runtime-error');
xhr.setRequestHeader('Content-Type', 'application/json;charset=UTF-8');
xhr.send(
JSON.stringify({
/* eslint-disable object-shorthand */
message: message,
source: source,
line: line,
column: column,
error: err && { message: err.message, name: err.name, stack: err.stack },
origin: 'preview',
/* eslint-enable object-shorthand */
})
);
};
</script>