Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook ^6.1.4 is not IE11 compatible #13314

Closed
beckerei opened this issue Nov 27, 2020 · 3 comments
Closed

Storybook ^6.1.4 is not IE11 compatible #13314

beckerei opened this issue Nov 27, 2020 · 3 comments
Assignees
@ghengeveld
Labels
bug ie11
Milestone
6.1.x

Comments

@beckerei
Copy link

Describe the bug
Syntax Error in IE11

Additional context
Introduced with d07c22d#diff-1ba439b44eefbba0e96d6d5e3fed47a889b4d5f669a6aa9e6baebedfb7e4dec1

JSON.stringify({ message, source, line, column, error, origin: 'preview' }),

IE11 does not understand object shorthand syntax.
@beckerei beckerei changed the title Storybook 6.1.7 is not IE11 compatible Storybook ^6.1.4 is not IE11 compatible Nov 27, 2020
@shilman shilman added this to the 6.1.x milestone Nov 27, 2020
@ghengeveld
Copy link
Member

😓 can't wait to drop IE support.

@beckerei
Copy link
Author

beckerei commented Dec 1, 2020 •
edited

@ghengeveld Can relate.

here is a lot of fun in working enterprise, but supporting IE11 is a downer.
I celebrated hard we were able to drop IE10 a few years ago ...

Let me know if I can help you out by taking this over.

@ghengeveld ghengeveld mentioned this issue Dec 1, 2020
Merged
@shilman
Copy link
Member

shilman commented Dec 3, 2020

Crikey!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.2.0-alpha.2 containing PR #13348 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghengeveld ghengeveld

Labels
bug ie11
Projects
None yet
Milestone
6.1.x
Development

No branches or pull requests
3 participants
@ghengeveld @shilman @beckerei