Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pg): remove unused context arg #7051

Merged
merged 1 commit into from Jul 26, 2023
Merged

refactor(pg): remove unused context arg #7051

merged 1 commit into from Jul 26, 2023

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Jul 21, 2023 •
edited

Description

insertInto has context param that is not used. This PR removes it.

Checklist

  • Investigated and inspected CI test results

If any of these don't apply, please comment below.

Testing Performed

CI

@janisz janisz requested review from a team as code owners July 21, 2023 11:19
@janisz
Copy link
Contributor Author

janisz commented Jul 21, 2023 •
edited

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@janisz janisz mentioned this pull request Jul 21, 2023
Merged
1 task
@janisz janisz requested a review from rhybrillou July 21, 2023 11:20
@roxbot
Copy link
Contributor

roxbot commented Jul 21, 2023 •
edited

Images are ready for the commit at 442cf15.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.1.x-535-g442cf1513f.

@janisz janisz requested a review from 0x656b694d July 24, 2023 18:23
@janisz
Copy link
Contributor Author

janisz commented Jul 25, 2023

@janisz started a stack merge that includes this pull request via Graphite.

Base automatically changed from refactor_remove_sotore_wrapper to master July 25, 2023 09:49
@janisz
Copy link
Contributor Author

janisz commented Jul 25, 2023

Graphite couldn't merge this PR because it had conflicts with the trunk branch.

@janisz janisz force-pushed the master-janisz/07-21-refactor_pg_remove_unused_context_arg branch from 3583538 to e87f4df Compare July 25, 2023 16:56
@janisz janisz changed the base branch from master to master-janisz/07-25-refactor_pg_extract_input_values_template July 25, 2023 18:25
@janisz janisz force-pushed the master-janisz/07-21-refactor_pg_remove_unused_context_arg branch from e87f4df to ccc4391 Compare July 25, 2023 18:26
@janisz janisz requested a review from a team as a code owner July 25, 2023 18:26
This was referenced Jul 25, 2023
Merged
Merged
Closed
Closed
Merged
Merged
@janisz janisz force-pushed the master-janisz/07-21-refactor_pg_remove_unused_context_arg branch from ccc4391 to 1078428 Compare July 25, 2023 18:27
@janisz
Copy link
Contributor Author

janisz commented Jul 26, 2023

/retest

@janisz
Copy link
Contributor Author

janisz commented Jul 26, 2023

@janisz started a stack merge that includes this pull request via Graphite.

@janisz janisz force-pushed the master-janisz/07-25-refactor_pg_extract_input_values_template branch from 1e64205 to d203da3 Compare July 26, 2023 09:15
Base automatically changed from master-janisz/07-25-refactor_pg_extract_input_values_template to master July 26, 2023 10:31
@janisz
Copy link
Contributor Author

janisz commented Jul 26, 2023

Graphite rebased this pull request as part of a merge.

@janisz janisz force-pushed the master-janisz/07-21-refactor_pg_remove_unused_context_arg branch from 1078428 to 442cf15 Compare July 26, 2023 10:31
@janisz janisz merged commit 311680e into master Jul 26, 2023
32 of 41 checks passed
@janisz
Copy link
Contributor Author

janisz commented Jul 26, 2023

@janisz merged this pull request with Graphite.

@janisz janisz deleted the master-janisz/07-21-refactor_pg_remove_unused_context_arg branch July 26, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorgorman connorgorman connorgorman approved these changes

@rhybrillou rhybrillou rhybrillou approved these changes

@0x656b694d 0x656b694d Awaiting requested review from 0x656b694d

Assignees
No one assigned
Labels
area/central area/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@janisz @roxbot @connorgorman @rhybrillou