Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pg): log queries in tests #6938

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Jul 14, 2023

Description

Sometimes when test are failing it's useful to see what queries were executed. This PR enables logging in DB after gorm creates tables to not output too many queries.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

CI

@roxbot
Copy link
Contributor

roxbot commented Jul 14, 2023

Images are ready for the commit at ec96cee.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.1.x-473-gec96cee4d2.

@janisz janisz force-pushed the master-janisz/07-14-test_pg_log_queries_in_tests branch from f3a3611 to 9e31bcd Compare July 14, 2023 15:28
@janisz janisz requested a review from dashrews78 July 18, 2023 10:50
@janisz janisz force-pushed the master-janisz/07-14-test_pg_add_test_for_nil_map_serialisation branch from 8f85554 to e6bb503 Compare July 20, 2023 11:16
@janisz janisz force-pushed the master-janisz/07-14-test_pg_log_queries_in_tests branch from 9e31bcd to ec96cee Compare July 20, 2023 11:16
@openshift-ci
Copy link

openshift-ci bot commented Jul 20, 2023

@janisz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-13-qa-e2e-tests 9e31bcd link false /test ocp-4-13-qa-e2e-tests
ci/prow/ocp-4-10-qa-e2e-tests 9e31bcd link false /test ocp-4-10-qa-e2e-tests
ci/prow/ocp-4-13-core-bpf-qa-e2e-tests 9e31bcd link false /test ocp-4-13-core-bpf-qa-e2e-tests
ci/prow/ocp-4-10-sensor-integration-tests ec96cee link false /test ocp-4-10-sensor-integration-tests
ci/prow/ocp-4-10-operator-e2e-tests ec96cee link false /test ocp-4-10-operator-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janisz janisz closed this Jul 20, 2023
@janisz janisz deleted the master-janisz/07-14-test_pg_log_queries_in_tests branch July 20, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants