-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dependencies): upgrade liquibase to 4.24.0 #1117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirangodishala
force-pushed
the
upgrade-liquibase
branch
from
November 13, 2023 13:12
3aecb75
to
3eae06b
Compare
kirangodishala
force-pushed
the
upgrade-liquibase
branch
from
November 15, 2023 02:51
3eae06b
to
bae4c14
Compare
dbyron-sf
reviewed
Nov 15, 2023
kork-sql/src/main/kotlin/com/netflix/spinnaker/kork/sql/migration/SpringLiquibaseProxy.kt
Outdated
Show resolved
Hide resolved
kirangodishala
force-pushed
the
upgrade-liquibase
branch
2 times, most recently
from
November 16, 2023 08:22
b914aa2
to
aa1e48d
Compare
dbyron-sf
reviewed
Nov 16, 2023
kork-sql/src/main/kotlin/com/netflix/spinnaker/kork/sql/migration/SpringLiquibaseProxy.kt
Outdated
Show resolved
Hide resolved
kirangodishala
force-pushed
the
upgrade-liquibase
branch
from
November 17, 2023 03:01
aa1e48d
to
028ee49
Compare
kirangodishala
force-pushed
the
upgrade-liquibase
branch
from
November 17, 2023 17:39
028ee49
to
678f00c
Compare
dbyron-sf
approved these changes
Nov 20, 2023
dbyron-sf
approved these changes
Nov 20, 2023
This was referenced Nov 21, 2023
dbyron-sf
added a commit
to dbyron-sf/kork
that referenced
this pull request
Dec 2, 2023
After spinnaker#1117, these comments are no longer relevant.
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
After #1117, these comments are no longer relevant.
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This liquibase upgrade PR
Some background is given below:
afterColumn
construct, with a validation error for postgresql.addAfterColumn is not allowed on postgresql
issue is fixed in 4.24.0 (Introducing removeChangeSetProperty feature liquibase/liquibase#3978)After merging this PR, Orca's changelog files will need some changes as per the liquibase fix introduced in 4.24.0.