chore(build): bump mysql driver and liquibase-core to latest #937
Conversation
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
juanpabloprado
changed the title
|
I encountered this issue on my Spinnaker instance, using MySQL as the Front50 backend. As @juanpabloprado figured out, this is related to Liquibase. Specifically, Liquibase fails to process the entries in its if (tmpDateExecuted instanceof Date) {
dateExecuted = (Date) tmpDateExecuted;
} else {
DateFormat df = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
try {
dateExecuted = df.parse((String) tmpDateExecuted);In my case, the A change was made to Liquibase on February 3, 2021 to support if (tmpDateExecuted instanceof Date) {
dateExecuted = (Date) tmpDateExecuted;
} else if (tmpDateExecuted instanceof LocalDateTime) {
dateExecuted = Date.from(((LocalDateTime) tmpDateExecuted).atZone(ZoneId.systemDefault()).toInstant());
} else {
DateFormat df = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
try {
dateExecuted = df.parse((String) tmpDateExecuted);From what I can tell this fix was first integrated into Liquibase v4.3.1, but this commit show many more tags that include it. @juanpabloprado why was the PR closed? Your proposed changes resolved the issue for me. |
|
I don't know if this the reason why the PR was closed, but the build did fail: I've been working on upgrading liquibase locally and I believe I'm seeing the same thing: I'm trying to track it down. |
|
@dbyron-sf have you tried v4.3.1? This is the earliest tag that contains the fix. The further you go from the current version, the more incompatibilities you're likely to encounter. |
|
I have....or at least it's still broken with v4.0.0. |
|
See also liquibase/liquibase#1916 |
|
Actually, I did some more testing and 4.3.1 does appear to work....at least the tests in kork-sql pass. More details in liquibase/liquibase#1916 (comment). I haven't actually tested it in a real environment, and at the moment I'm not planning to...since I'm really looking for a version that fixes CVE-2022-0839 which requires >= 4.8.0. |
|
I filed liquibase/liquibase#2818. |
|
Hi folks! I landed here from the various related liquibase issues. I started seeing this same error building keel today, but pinning to 4.3.1 or lower doesn't fix the issue for me. Any other clues you may have found by chance? |
|
Not sure how helpful this is, but in the testing I've done, newer liquibases (e.g. 4.10.0, 4.11.0, and older ones...not sure how much older) work everywhere in spinnaker except kork. Like, the only failures are from |
|
@luispollo @dbyron-sf do you know if anybody is looking at fixing this in Kork? As you say, the actual Spinnaker services run fine - we're able to deploy them using 8.0.29/4.13.0 respectively, but kork-sql tests fail because of the issue linked above. Reading through it seems like we should just be able to set the duplicateFile property and bump them? Although I'm not sure where that property needs to be set - I still see errors with the property set in the test class and in |
|
I have most of the changes done to move to liquibase 4.13.0...no change to the mysql driver. The current (and I think last) snag is that orca has tests that use postgres and postgres doesn't support |
|
And #970. |
|
And finally, #1117. |
I see there is no liquibase-core version specified, I've tested on clouddriver running locally, I had problems during the migration by liquibase, when using latest mysql driver i.e.
and by upgrading the liquibase version, I got it working
See discussion on stackoverflow