Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed kork-sql module testcases #103

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fixed kork-sql module testcases #103

merged 1 commit into from
Dec 11, 2023

Conversation

SusmithaGundu
Copy link

@SusmithaGundu SusmithaGundu commented Dec 6, 2023

jira : https://devopsmx.atlassian.net/browse/OP-21387
Test cases in kork-sql module were failing with two exceptions:

  1. invalid configuration of spring-profiles and complaining to change from 'spring.profiles' to 'spring.config.activate.on-profile'. Hence changed this in application.yml file
  2. Liquibase is complaining of finding duplicate healthcheck.yml file one in src/main/resources and the other in jar files in build directory where as both are same and this is a bug in liquibase for which a workaround was provided to add 'duplicateFileMode: WARN' while configuring liquibase in project. this was already fixed in oss and added the same changes from oss to fix this issue.
    Reference for oss PR:
    chore(dependencies): upgrade liquibase to 4.24.0 spinnaker/kork#1117

other references:
liquibase/liquibase#3006

Verified that build is successful and test cases are passing

Copy link

@kirangodishala kirangodishala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aman-agrawal aman-agrawal merged commit fa64f79 into OpsMx:OES-1.30.x-master-adhoc Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants