Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Build: Allow new datetime behavior in PyYAML 5.3 #1125

Merged
merged 1 commit into from Jan 15, 2020

Conversation

dtkav
Copy link
Collaborator

@dtkav dtkav commented Jan 15, 2020

Fixes Master, which is broken due to PyYAML change in 5.3
yaml/pyyaml#163

Changes proposed in this pull request:

  • update test to not expect Zulu datetime ending, as PyYAML 5.3 parses the date as TZ aware

@dtkav dtkav changed the title update tests to allow new datetime behavior in PyYAML 5.3 Fixes Build: Allow new datetime behavior in PyYAML 5.3 Jan 15, 2020
@dtkav
Copy link
Collaborator Author

dtkav commented Jan 15, 2020

@hjacobs master is broken due to a change in PyYAML ( yaml/pyyaml#163 ).
This change seems reasonable to me (loading a spec with a datetime+tz will make a tz-aware datetime).
Alternatively we could pin 5.2, or 5.3 and choose one behavior. This PR accepts both.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.284% when pulling f575f0e on dtkav:pyyaml_5_3_datetime_update into f55cb1c on zalando:master.

@hjacobs
Copy link
Contributor

hjacobs commented Jan 15, 2020

👍

@hjacobs hjacobs merged commit 0766df5 into spec-first:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants