Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pythonic path param types in aiohttp #1127

Merged
merged 2 commits into from
Jan 15, 2020
Merged

fix pythonic path param types in aiohttp #1127

merged 2 commits into from
Jan 15, 2020

Conversation

dtkav
Copy link
Collaborator

@dtkav dtkav commented Jan 15, 2020

Fixes #1116

@dtkav dtkav added the bugfix label Jan 15, 2020
@dtkav
Copy link
Collaborator Author

dtkav commented Jan 15, 2020

note, this is already rebased ontop of #1125
#1125 should be merged first.

dtkav
dtkav commented Jan 15, 2020
View reviewed changes
tests/aiohttp/test_aiohttp_datetime.py
@@ -27,7 +27,10 @@ def get_value(data, path):
return data

example = get_value(spec_data, 'paths./datetime.get.responses.200.content.application/json.schema.example.value')
assert example == '2000-01-23T04:56:07.000008Z'
assert example in [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from #1125

dtkav
dtkav commented Jan 15, 2020
View reviewed changes
tests/test_flask_encoder.py
@@ -63,7 +63,10 @@ def get_value(data, path):
return data

example = get_value(spec_data, 'paths./datetime.get.{}.example.value'.format(response_path))
assert example == '2000-01-23T04:56:07.000008Z'
assert example in [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from #1125

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.284% when pulling 667ceba on dtkav:bug/1116/sanitized_path_param_types_aiohttp into f55cb1c on zalando:master.

@hjacobs
Copy link
Contributor

hjacobs commented Jan 15, 2020

👍

@hjacobs hjacobs merged commit 77f2861 into spec-first:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pythonic_params do not convert the parameter type
3 participants
@dtkav @coveralls @hjacobs