Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken by datetime changes in PyYAML 5.3 #1126

Closed
dtkav opened this issue Jan 15, 2020 · 1 comment
Closed

Build broken by datetime changes in PyYAML 5.3 #1126

dtkav opened this issue Jan 15, 2020 · 1 comment
Labels

Comments

@dtkav
Copy link
Collaborator

dtkav commented Jan 15, 2020

Description

The following change to PyYAML ( yaml/pyyaml#163 ) altered the behavior of loading yaml files.
As of PyYAML 5.3, datetime strings like 2020-01-01T00:00:00+00:00 will be loaded as timezone-aware datetimes.

Expected behaviour

This test currently rely on PyYAML loading TZ-naive datetimes:
https://github.com/zalando/connexion/blob/master/tests/test_flask_encoder.py#L66

PyYAML < 5.3 will return 2000-01-23T04:56:07.000008Z
PyYAML >= 5.3 will return 2000-01-23T04:56:07.000008+00:00

We should update the tests to allow the changes in PyYAML 5.3

Actual behaviour

We currently depend on the timezone-naive yaml loader from PyYAML < 5.3

Steps to reproduce

Run Travis CI on master

Potential Fix

#1125

@dtkav dtkav pinned this issue Jan 15, 2020
@dtkav dtkav added the bug label Jan 15, 2020
@dtkav dtkav closed this as completed Jan 17, 2020
@dtkav
Copy link
Collaborator Author

dtkav commented Jan 17, 2020

closed by #1125

@dtkav dtkav unpinned this issue Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant