Support for asset retries, and deleting existing releases #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Thanks for the pull. there's actually an oktokit plugin that implements this for you. If possible I'd love to use this as the standard approach before implementing a custom retry implementation. |
ncfavier
added a commit
to ncfavier/action-gh-release
that referenced
this pull request
Dec 4, 2021
Extracted from softprops#181
ncfavier
added a commit
to ncfavier/action-gh-release
that referenced
this pull request
Dec 5, 2021
Extracted from softprops#181
ncfavier
added a commit
to ncfavier/action-gh-release
that referenced
this pull request
Mar 13, 2022
Extracted from softprops#181
ncfavier
added a commit
to ncfavier/action-gh-release
that referenced
this pull request
Mar 13, 2022
Extracted from softprops#181
ncfavier
added a commit
to ncfavier/action-gh-release
that referenced
this pull request
Mar 13, 2022
Extracted from softprops#181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, we're using this internally for some CI operations that take a considerable amount of time (5 hours) where this action is the last step of that process.
We ran into a GitHub downtime right as it came time to create the release and the upload assets failed only due to connectivity issues and since there is no upload retry mechanism we ended up having to do another 5 hour CI build.
We've added an option to retry asset uploads along with the ability to set an interval between retries.
Additionally we've added a
delete_on_existingoption to allows us to completely regenerate a release each time we run CI.