Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please retry uploading when failed. #187

Open
abcfy2 opened this issue Nov 29, 2021 · 11 comments
Open

Please retry uploading when failed. #187

abcfy2 opened this issue Nov 29, 2021 · 11 comments

Comments

@abcfy2
Copy link
Contributor

abcfy2 commented Nov 29, 2021

Sometimes I will get this error https://github.com/abcfy2/aria2-static-build/runs/4349111525?check_suite_focus=true:

Run softprops/action-gh-release@v1
/usr/bin/docker exec  356d60f2fa6f6229b94833f4ef730b7baa9d4f62c9f0341db5214911e5c29164 sh -c "cat /etc/*release | grep ^ID"
⬆️ Uploading aria2-aarch64-linux-musl_static.zip...
Error: request to https://uploads.github.com/repos/abcfy2/aria2-static-build/releases/54209979/assets?name=aria2-aarch64-linux-musl_static.zip failed, reason: read ECONNRESET

Please retry when uploading failed. Thanks.

@wez
Copy link

wez commented Dec 4, 2021

Note that when using the GH Actions "rerun all jobs" after encountering this error, you can encounter #166 instead, which requires deleting the half-uploaded files before re-running the jobs again will succeed.

@wez
Copy link

wez commented Dec 4, 2021

#181 seems relevant

@softprops
Copy link
Owner

If release assets share the same name they should be deleted when a release is reattempted

console.log(`♻️ Deleting previously uploaded asset ${name}...`);

@abcfy2
Copy link
Contributor Author

abcfy2 commented Dec 6, 2021

@softprops Would you please add this feature? I'm facing this issue just now.

abcfy2 added a commit to abcfy2/action-gh-release that referenced this issue Jan 23, 2022
abcfy2 added a commit to abcfy2/action-gh-release that referenced this issue Jan 23, 2022
@jonasmusall
Copy link

I am facing the same issue. Right now, I use this workaround:

steps:
  - name: Upload assets
    id: upload_try1
    continue-on-error: true
    uses: softprops/action-gh-release@v1
    with:
      files: ${{ env.RELEASE_ASSETS }}
  - name: Upload assets (retry)
    id: upload_try2
    if: steps.upload_try1.outcome == 'failure'
    continue-on-error: true
    uses: softprops/action-gh-release@v1
    with:
      files: ${{ env:RELEASE_ASSETS }}
# more retries

@z64555
Copy link

z64555 commented Feb 26, 2022

+1 for this feature.

We're having an issue with uploading several .zip's from our build chain to the Release file host on Github. Most of them are successful but one or two have been consistently failing with ECONNRESET since around December 2021 or so. Thankfully we were able to come up with a manual workaround by stashing the .zip's as an artifact to the workflow instead of needing to re-run the entire build chain.

During my experiments to find a workaround, a short delay of 5 or 15s did not prevent ECONNRESET from occurring.

@bergentroll
Copy link

E.g. ncipollo/release-action do the job.

benalexau added a commit to benalexau/aur-repo that referenced this issue Jun 16, 2022
ncipollo/release-action provides automatic retries whereas such
behaviour is currently unavailable in action-gh-release as per
softprops/action-gh-release#187
@russkel
Copy link

russkel commented Jun 22, 2022

The release already existed when I was trying to replace the assets. This failed about 5 times until I deleted the release entirely.

@bokan
Copy link

bokan commented Nov 15, 2022

Any updates on this?

@Haaroon
Copy link

Haaroon commented Dec 6, 2022

this constantly fails, do not use this workflow

@Mpaape
Copy link

Mpaape commented May 9, 2023

i used https://github.com/ncipollo/release-action and that solved my same problem...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants