Failing helper overload spec #1655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't look like this spec is failing, can you double check this? Thank you for working on this, a failing spec will be very helpful. |
|
File had wrong name... |
|
@namusyaka do you have any thoughts on this? Should we plan on reverting the change in #1213? |
|
@jkowens Yes, we should revert the change, it shouldn't be merged into v2.1.0 (probably v3.0.0 seems good). |
namusyaka
added a commit
that referenced
this pull request
Nov 4, 2020
|
Merged in #1662 , thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.