Use prepend instead of include for helpers. Fixes #1213

[mwpastore]

No description provided.

[zzak]

See my comment on #1213

[mwpastore]

I did. 😄 This can wait. My only counterargument would be that there's never going to be a better time to break things, so if this makes sense, let's do it. The counterargument to that is that 2.0's already been in pre-release for ages and cramming things in at the end of the cycle isn't kosher. Anyway, I'm fine waiting, and if you are feeling like you'll never want to merge it, that's fine too.

[zzak]

@mwpastore Please wait 🙇

[namusyaka]

Sorry for the late reply, but thanks. This looks reasonable to me.
You should also work on sinatra-namespace.

[baelter]

Ouch, this broke a lot of things. Helpers are not overloaded like before.

[aldentea]

Yes. If a helper module uses included method, it doesn't work.

[jkowens]

Hm not good. @baelter / @aldentea would you be able to submit a PR with a failing test?

[baelter]

@jkowens
Here you go, this works in v2.0.8.1
#1655

[baelter]

Could use prepend(Module.new(&block)) instead of class_eval(&block) but then that does not play nice with alias_method. I don't think it's possible to combine prepend and alias_method.