Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpers test to confirm helpers are included. #1656

Closed
wants to merge 1 commit into from
Closed

Add helpers test to confirm helpers are included. #1656

wants to merge 1 commit into from

Conversation

aldentea
Copy link
Contributor

#1214 brought a side effect which made some already-existing helpers unavailable.
This test passes on Sinatra 2.0.8.1, but fails on 2.1.0.

@dentarg
Copy link
Member

dentarg commented Oct 27, 2020

Same as #1655?

@aldentea
Copy link
Contributor Author

aldentea commented Oct 27, 2020 •
edited

@dentarg Maybe not the same as #1655 . My gut tells there seems a solution which resolve one and doesn't resolve the other.

@namusyaka
Copy link
Member

Merged in #1662 , thanks.

@namusyaka namusyaka closed this Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aldentea @dentarg @namusyaka @jkowens