chore(npm): add ci-or-install script #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a script which checks the npm version and runs either `npm ci` or `npm install` based on support. This is primarily to work around an issue where `npm install` modifies `package-lock.json` for newer npm versions. A side benefit is that `npm ci` is slightly faster than `npm install`. Fixes #893
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 34 34
Lines 1266 1266
=======================================
Hits 1213 1213
Misses 53 53Continue to review full report at Codecov.
|
nfischer
added a commit
that referenced
this pull request
Nov 29, 2018
This removes our lockfile and our `ci-or-install` script. The lockfile caused headaches, since `npm install` would modify the lockfile. Unfortunately, `ci-or-install` (added in #896) didn't work reliably on appveyor, so removing the lockfile seems easier. We remove the script since it's now obsolete. Fixes #893
nfischer
added a commit
that referenced
this pull request
Nov 29, 2018
This removes our lockfile and our `ci-or-install` script. The lockfile caused headaches, since `npm install` would modify the lockfile. Unfortunately, `ci-or-install` (added in #896) didn't work reliably on appveyor, so removing the lockfile seems easier. We remove the script since it's now obsolete. Fixes #893
This was referenced Nov 29, 2018
nfischer
added a commit
that referenced
this pull request
Nov 30, 2018
This removes our lockfile and our `ci-or-install` script. The lockfile caused headaches, since `npm install` would modify the lockfile. Unfortunately, `ci-or-install` (added in #896) didn't work reliably on appveyor, so removing the lockfile seems easier. We remove the script since it's now obsolete. Fixes #893
This was referenced Nov 29, 2019
This was referenced Mar 24, 2020
This was referenced Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a script which checks the npm version and runs either
npm cior
npm installbased on support. This is primarily to work around anissue where
npm installmodifiespackage-lock.jsonfor newer npmversions.
A side benefit is that
npm ciis slightly faster thannpm install.Fixes #893