chore(npm): remove lockfile #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes our lockfile and our `ci-or-install` script. The lockfile caused headaches, since `npm install` would modify the lockfile. Unfortunately, `ci-or-install` (added in #896) didn't work reliably on appveyor, so removing the lockfile seems easier. We remove the script since it's now obsolete. Fixes #893
Codecov Report
@@ Coverage Diff @@
## master #911 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 34 34
Lines 1271 1271
=======================================
Hits 1237 1237
Misses 34 34Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes our lockfile and our
ci-or-installscript. The lockfilecaused headaches, since
npm installwould modify the lockfile.Unfortunately,
ci-or-install(added in #896) didn't work reliably onappveyor, so removing the lockfile seems easier. We remove the script
since it's now obsolete.
Fixes #893