Skip to content

Commit

Permalink
chore(npm): remove lockfile
Browse files Browse the repository at this point in the history
This removes our lockfile and our `ci-or-install` script. The lockfile
caused headaches, since `npm install` would modify the lockfile.

Unfortunately, `ci-or-install` (added in #896) didn't work reliably on
appveyor, so removing the lockfile seems easier. We remove the script
since it's now obsolete.

Fixes #893
  • Loading branch information
nfischer committed Nov 29, 2018
1 parent 26d6e0e commit f3ec88e
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 8,102 deletions.
3 changes: 3 additions & 0 deletions .npmrc
@@ -0,0 +1,3 @@
# We can't use lockfiles because npm@5 and npm@6 disagree about the syntax (and
# will modify the lockfile when we run `npm install`).
package-lock=false
2 changes: 0 additions & 2 deletions .travis.yml
Expand Up @@ -8,8 +8,6 @@ node_js:
- 8
- 9

install:
- npm run ci-or-install
os:
- linux
- osx
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
Expand Up @@ -15,7 +15,7 @@ install:
- set PATH=%APPDATA%\npm;%PATH%
- node --version
- npm --version
- npm run ci-or-install
- npm install

matrix:
fast_finish: false
Expand Down

0 comments on commit f3ec88e

Please sign in to comment.