Skip to content

Meeting 2014 10 06

larsbergstrom edited this page Oct 6, 2014 · 1 revision

Agenda

  • spidermonkey review (jdm)
  • html5ever review (kmc)
  • cargo (mbrubeck)
  • build stuff (jack)
  • text input (jdm)
  • newbors (jack)

Attending

  • jdm, larsberg, Manishearth, cgaebel, zwarich, mbrubeck, Ms2ger, brson, jack, kmc, pcwalton

Spidermonkey review

  • jdm: Cameron and ms2ger are reviewing it. I've addressed comments. I think it's now back on them.
  • jack: Land soon?
  • jdm: This week... potentially? If all goes well.
  • jack: What else is involved?
  • jdm: Need to decide what to do about rust-mozjs. One more thing to write, which I forgot in the initial thing, which an SM hacker brought up.
  • jack: Revert the rust-mozjs PR that landed? Or does that mess things up? I don't mind messing with the history there. There are no consumers apart from us.
  • jdm: OK.
  • jack: Also, it's never been bumped in a submodule pointer in SErvo, so none of the builders should have it.

html5ever

  • jack: Are people reviewing it?
  • kmc: Simon said he looked at parts of it. He opened some PRs for a few issues, which I've merged. Not a full review done yet, though I'd be OK with landing the change given the reviews to this point. The integration is ready. But the major part that would have required rebasing (namespace stuff) has already landed.
  • jack: Servo integration reviewed yet?
  • kmc: Not yet. ms2ger says he would like to look at it more.
  • jack: I'd like to have somebody review some of it more. None of us have reviewed the C library code for hubbub, though, so this can only be better.
  • kmc: Will open the integration PR today, then!

Cargo

  • mbrubeck: If my latest PR lands, a new Cargo will be required
  • jack: But don't upgrade past the October second nightly!
  • mbrubeck: Yes. That's prevented automatically in Servo master.
  • larsberg: Should we move to an LKG model for Cargo?
  • jack: Basically what we've done, since bootstrap is now hardcoded to 10/2.
  • zwarich: It's like groundhog day, for Cargo!
  • jack: Figured this would happen eventually being on nightly, but hoped it would be a while. I don't think acrichto has figured out what they did.
  • mbrubeck: Cargo prevents all your dependencies from breaking you... except for Cargo itself!

Build stuff

  • jack: Apart from cargo, has anybody seen stuff from bors? And the PR links being broken? I suspect github changed their links in the JSON, since it was working last week. brson, did you see that in Rust bors?
  • brson: Nobody has brought it to my attention yet.
  • jack: You should be able to see it on the bors status page.
  • brson: rust bors is still operational - the links work.
  • jack: ms2ger is investigating.

Text input

  • jdm: I'm taking volunteers to review it! There is a PR now. Or no-text-input-for-you!
  • zwarich: That solves the problems related to youtube comments!
  • jack: Evil-jack nominates gw.
  • jdm: +1.
  • zwarich: Simon is also not here, so maybe the other half?
  • jack: I think he wants to do html5ever integration :-)

newbors

  • jack: I have a bunch of it working. It triggers off of commit comments, so responds instantly and can find the PR, check that it's mergeable, etc. The only thing left is to create the merge branch and use the GH APIs to merge to auto. That involves scheduling, though (since you only want one going at a time), but it's getting pretty close. Seems a lot simpler than the old pull model. Not a lot of time to work on it this week because there's an offsite and then I'm on PTO. So maybe trial mode in a couple of weeks?

encoding

  • jack: Make sure to check out the very interesting WTF-8 discussion on dev-servo!
Clone this wiki locally