ci: Use jupyter-black pre-commit hook over nbqa-black
#1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1598 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 63 63
Lines 4050 4050
Branches 576 576
=======================================
Hits 3957 3957
Misses 54 54
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
MarcoGorelli
reviewed
Sep 7, 2021
.pre-commit-config.yaml
Outdated
Comment on lines
37
to
38
| - id: black | ||
| - id: black-jupyter |
There was a problem hiding this comment.
black-jupyter will run on Python and pyi files as well, you probably only need that one
There was a problem hiding this comment.
That's awesome. :)
This was referenced Sep 12, 2021
4 tasks
matthewfeickert
added a commit
that referenced
this pull request
Feb 15, 2022
* Remove .coveragerc and consolidate pytest options to pyproject.toml. * Apply 'configuring pytest' recommendations for pytest from Scikit-HEP (c.f. https://scikit-hep.org/developer/pytest#configuring-pytest ). - '-ra' includes a report after pytest runs with a summary on all tests except those that passed. From 'pytest --help': > -r chars: show extra test summary info as specified by chars: (f)ailed, > (E)rror, (s)kipped, (x)failed, (X)passed, (p)assed, (P)assed with output, > (a)ll except passed (p/P), or (A)ll. (w)arnings are enabled by default > (see --disable-warnings), 'N' can be used to reset the list. (default: 'fE'). - '--showlocal' prints locals in tracebacks. - '--strict-markers' will complain if you use an unspecified fixture. - '--strict-config' will raise an error if there is a mistake in the pytest config. - 'log_cli_level = "info"' reports INFO and above log messages on a failure. - 'filterwarnings = ["error"]' sets all warnings to be errors and allows for some warnings to be ignored with -W warn control syntax. (c.f. https://docs.python.org/dev/using/cmdline.html#cmdoption-W ) * Remove `tests/__init__.py` as no reason to make the tests directory importable. * Remove '-r sx' from pytest calls in CI jobs as pyproject.toml now applies '-ra'. * Use 'with pytest.warns' to assert expected warnings in tests. (c.f. https://docs.pytest.org/en/7.0.x/how-to/capture-warnings.html#warns ) * Override error on filterwarnings for the 'minimum supported dependencies' GHA workflow as it is testing for the oldest releases that work with the latest API, not the oldest releases that are warning free. * Remove unused nbQA options for black from pyproject.toml. - Amends PR #1598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1594
Wit the addition of the
jupyter-blackhook by @MarcoGorelli (c.f. psf/black#2357) inblackv21.8b0thenbqa-blackhook has essentially been contributed to Black and nownbqa-blackis no longer needed. This has the additional advantage of being tied to the Black version directly and doesn't require updating the Black version as anadditional_dependenciesofnbqa-blackand also that theblackhook id is now also contained inblack-jupyter.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: