Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use jupyter-black pre-commit hook over nbqa-black #1598

Merged
merged 3 commits into from Sep 7, 2021
Merged

ci: Use jupyter-black pre-commit hook over nbqa-black #1598

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36c2589
Remove nbqa-black hook
matthewfeickert Sep 7, 2021
41cbe9b
Add black-jupyter hook id
matthewfeickert Sep 7, 2021
226f704
Use black-jupyter for everything
matthewfeickert Sep 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Expand Up @@ -35,6 +35,7 @@ repos:
rev: 21.8b0
hooks:
- id: black
- id: black-jupyter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black-jupyter will run on Python and pyi files as well, you probably only need that one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome. :)


- repo: https://github.com/asottile/blacken-docs
rev: v1.11.0
Expand All @@ -52,5 +53,3 @@ repos:
hooks:
- id: nbqa-pyupgrade
additional_dependencies: [pyupgrade==2.25.0]
- id: nbqa-black
additional_dependencies: [black==21.8b0]